-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use URL path template when tracing REST clients where possible #39534
Conversation
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luneo7 The IT tests using the client will need to be updated as well.
1b61652
to
b78e585
Compare
b78e585
to
d7b1ca5
Compare
Done =] |
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luneo7!
@brunobat can merge it at his discression :) |
Thank you! Could this be backported as well? |
Added the label. |
This is breaking change and not exactly fun to look for what changed. Please add a note to the migration guide for people like me, thank you. |
My point is that |
Added a wiki entry. @michalvavrik |
Thank you |
Use URL path template in the REST client span names where possible.
Using raw Vert.x web client is not possible right now since all the instrumentation happens after
UriTemplate
is applied so we have only the full URI... this would make is have infinite cardinality since a path variable can lead to infinite URLs. Ideally the Vert.x web client could expose the usedUriTemplate
during tracing or formetrics
(as we have with VertxRoute right now) so we could extract it and build the span name with the template as well.Now RestEasy clients using Vert.x or not will be with a span name of
{method} {urlPathTemplate}
as we had before =]