-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hibernate ORM package/class processing rules #39715
Update Hibernate ORM package/class processing rules #39715
Conversation
According to documentation, this is an incorrect assumption: https://quarkus.io/guides/hibernate-orm#multiple-persistence-units-attaching-model-classes |
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java
Outdated
Show resolved
Hide resolved
3b4f8fa
to
e94f9d5
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Two things to note though:
- You added the tests to the
jpa-postgresql
integration tests, which is quite odd. This is not specific to postgres, is it? And there's nothing specific to native compilation, either? If so I'd have expected the test to be inextensions/hibernate-orm/deployment/src/test/java
. - I understand the problem with recursive packages, but I'm not quite sure why you had to do it in the same commit as the actual fix, and I suspect if we change this "for correctness", we'd want to update other ITs as well? (jpa-h2, jpa-mysql, ...)
Anyway... None of this should block the merging of this PR, so +1 to merge when you're ready @marko-bekhta.
e94f9d5
to
9d58018
Compare
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Native Tests - Data4 | Upload build reports |
Logs | Raw logs | 🚧 | |
✖ | Quickstarts Compilation - JDK 17 | Compile Quickstarts |
Failures | Logs | Raw logs | 🚧 |
Failures
⚙️ Quickstarts Compilation - JDK 17 #
- Failing: security-webauthn-quickstart security-webauthn-reactive-quickstart
📦 security-webauthn-quickstart
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project security-webauthn-quickstart: Compilation failure
📦 security-webauthn-reactive-quickstart
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project security-webauthn-reactive-quickstart: Compilation failure
fixes #39299
I am not 100% sure about the changes in the first commit, but I'd expect that the package list should be explicit and not include subpackages. With the current behaviour DB objects for
other
PU in our tests were created by "accident" since the other pu did not explicitly define the properties to create them...