Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hibernate ORM package/class processing rules #39715

Merged

Conversation

marko-bekhta
Copy link
Contributor

fixes #39299

I am not 100% sure about the changes in the first commit, but I'd expect that the package list should be explicit and not include subpackages. With the current behaviour DB objects for other PU in our tests were created by "accident" since the other pu did not explicitly define the properties to create them...

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Mar 26, 2024
Copy link

quarkus-bot bot commented Mar 26, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@yrodiere
Copy link
Member

I am not 100% sure about the changes in the first commit, but I'd expect that the package list should be explicit and not include subpackages

According to documentation, this is an incorrect assumption:

image

https://quarkus.io/guides/hibernate-orm#multiple-persistence-units-attaching-model-classes

@marko-bekhta marko-bekhta force-pushed the fix/i39299-orm-annotations-on-package-info branch from 3b4f8fa to e94f9d5 Compare March 26, 2024 17:42

This comment has been minimized.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Two things to note though:

  1. You added the tests to the jpa-postgresql integration tests, which is quite odd. This is not specific to postgres, is it? And there's nothing specific to native compilation, either? If so I'd have expected the test to be in extensions/hibernate-orm/deployment/src/test/java .
  2. I understand the problem with recursive packages, but I'm not quite sure why you had to do it in the same commit as the actual fix, and I suspect if we change this "for correctness", we'd want to update other ITs as well? (jpa-h2, jpa-mysql, ...)

Anyway... None of this should block the merging of this PR, so +1 to merge when you're ready @marko-bekhta.

@marko-bekhta marko-bekhta force-pushed the fix/i39299-orm-annotations-on-package-info branch from e94f9d5 to 9d58018 Compare March 27, 2024 08:36
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 27, 2024
Copy link

quarkus-bot bot commented Mar 27, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9d58018.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Data4 Upload build reports ⚠️ Check → Logs Raw logs 🚧
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs 🚧

Failures

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: security-webauthn-quickstart security-webauthn-reactive-quickstart 

📦 security-webauthn-quickstart

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project security-webauthn-quickstart: Compilation failure

📦 security-webauthn-reactive-quickstart

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project security-webauthn-reactive-quickstart: Compilation failure

@gsmet gsmet merged commit a58edc4 into quarkusio:main Mar 28, 2024
36 of 38 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 28, 2024
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 28, 2024
@gsmet gsmet modified the milestones: 3.10 - main, 3.8.4 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate ORM: package-info is ignored when specifying scan packages
3 participants