-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3949 #3978
Merged
Merged
Fixes #3949 #3978
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes #3949
If a checked exception is thrown from an interceptor allow RESTeasy exception mappers to unwrap it.
- Loading branch information
commit bdfafda7ff811a62ff78e9c50f18e99e4141424c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/ArcUndeclaredThrowableException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package io.quarkus.arc; | ||
|
||
/** | ||
* Exception that is thrown from generated arc classes if a checked exception cannot be propagated | ||
*/ | ||
public class ArcUndeclaredThrowableException extends RuntimeException { | ||
|
||
public ArcUndeclaredThrowableException(Throwable cause) { | ||
super(cause); | ||
} | ||
|
||
public ArcUndeclaredThrowableException() { | ||
super(); | ||
} | ||
|
||
public ArcUndeclaredThrowableException(String message) { | ||
super(message); | ||
} | ||
|
||
public ArcUndeclaredThrowableException(String message, Throwable cause) { | ||
super(message, cause); | ||
} | ||
|
||
protected ArcUndeclaredThrowableException(String message, Throwable cause, boolean enableSuppression, | ||
boolean writableStackTrace) { | ||
super(message, cause, enableSuppression, writableStackTrace); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if the name shouldn't be more general, something like
ArcException
so that we could use it for similar use cases. Note that we have such exception in Weld too:org.jboss.weld.exceptions.WeldException
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very specific use case, it should not be used for general exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very specific use case, it should not be used for general exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, TBH I don't understand the name - why
UndeclaredThrowable
? In the linked reproducer theRollbackException
is thrown by a JTA interceptor, or? Shouldn't we name itSubclassInvocationException
or something like that?