Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JDK version to 17 as an aws lambda runtime in aws-lambda related extensions #39822

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Bump JDK version to 17 as an aws lambda runtime in aws-lambda related extensions #39822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/aws-lambda-http.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,10 @@
----
Properties:
Handler: io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler::handleRequest
Runtime: java11
Runtime: java17
----

This handler is a bridge between the lambda runtime and the Quarkus HTTP framework you are using (Jakarta REST, Servlet, etc.)

Check warning on line 271 in docs/src/main/asciidoc/aws-lambda-http.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.TermsSuggestions] Depending on the context, consider using 'by using' or 'that uses' rather than 'using'.

Raw Output:
{"message": "[Quarkus.TermsSuggestions] Depending on the context, consider using 'by using' or 'that uses' rather than 'using'.", "location": {"path": "docs/src/main/asciidoc/aws-lambda-http.adoc", "range": {"start": {"line": 271, "column": 91}}}, "severity": "INFO"}

Check warning on line 271 in docs/src/main/asciidoc/aws-lambda-http.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.TermsWarnings] Consider using 'and so on' rather than 'etc' unless updating existing content that uses the term.

Raw Output:
{"message": "[Quarkus.TermsWarnings] Consider using 'and so on' rather than 'etc' unless updating existing content that uses the term.", "location": {"path": "docs/src/main/asciidoc/aws-lambda-http.adoc", "range": {"start": {"line": 271, "column": 122}}}, "severity": "WARNING"}

If you want to go native, there's an environment variable that must be set for native GraalVM deployments. If you look at `sam.native.yaml`
you'll see this:
Expand Down
2 changes: 1 addition & 1 deletion extensions/amazon-lambda-http/deployment/src/main/resources/http/sam.jvm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
Type: AWS::Serverless::Function
Properties:
Handler: io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler::handleRequest
Runtime: java11
Runtime: java17
CodeUri: function.zip
MemorySize: 512
Policies: AWSLambdaBasicExecutionRole
Expand Down
2 changes: 1 addition & 1 deletion extensions/amazon-lambda-rest/deployment/src/main/resources/http/sam.jvm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
Type: AWS::Serverless::Function
Properties:
Handler: io.quarkus.amazon.lambda.runtime.QuarkusStreamHandler::handleRequest
Runtime: java11
Runtime: java17
CodeUri: function.zip
MemorySize: 512
Policies: AWSLambdaBasicExecutionRole
Expand Down
2 changes: 1 addition & 1 deletion extensions/amazon-lambda/common-deployment/src/main/resources/lambda/manage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function cmd_update() {

FUNCTION_NAME=${lambdaName}
HANDLER=${handler}
RUNTIME=java11
RUNTIME=java17
ZIP_FILE=${targetUri}

function usage() {
Expand Down
2 changes: 1 addition & 1 deletion extensions/amazon-lambda/common-deployment/src/main/resources/lambda/sam.jvm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: ${handler}
Runtime: java11
Runtime: java17
CodeUri: function.zip
MemorySize: 256
Timeout: 15
Expand Down
Loading