Adjust some user-visible references to RESTEasy Reactive #39929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/amazon-lambda
area/hibernate-validator
gsmet
reviewed
Apr 7, 2024
...ions/spring-web/resteasy-reactive/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
|
And as for references to RESTEasy Reactive: yes, there are still a lot in the code base. The idea wasn't to make it disappear, just to change the branding on the user side (which is what you are doing here). Making it disappear from the codebase would be a big backporting nightmare so it was decided to keep the changes small - and it ended up being a massive PR even even with keeping it small. (And it actually made things harder as it wasn't a simple search/replace) |
This comment has been minimized.
This comment has been minimized.
holly-cummins
force-pushed
the
remove-some-visible-resteasy-reactives
branch
from
d7ad950 to
f3c8214
Compare
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Native Tests - Misc4 | Download .m2/repository/io/quarkus |
Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
gsmet
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags: Big Reactive Rename, #BigReactiveRename, #BRR, 🥶
While practicing a demo for JProfessionals, I noticed a message in the dev UI that said “Learn how to write REST Services with RESTEasy Reactive.” (For some reason the Dev UI was a bit slow to detect the endpoints that definitely existed, but that's a different issue.)
When I looked in the code I saw that message was definitely still in the codebase, so it wasn't just a caching thing. In fact, there are quite a few references to RESTEasy Reactive. Fixing them all looked like it would be hard work to do and then hard to review, so I've tackled one chunk of the elephant, and done the reference that I saw, plus any that are visible in http://extensions.quarkus.io.
See, for example,