Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs OIDC Client - Inconsistent variable naming, OidcClientCreator example #39956

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Docs OIDC Client - Inconsistent variable naming, OidcClientCreator example #39956

merged 1 commit into from
Apr 9, 2024

Conversation

ZanHorvat
Copy link
Contributor

This pull request addresses a minor issue in docs:

  • /guides/security-openid-connect-client-reference#use-oidc-clients

Inconsistent variable naming, which was introduced at the last doc update.

@ZanHorvat
Inconsistent variable naming - OIDC Client docs, OidcClientCreator.
60eb646 
Signed-off-by: Žan Horvat <zhorvat0716@gmail.com>
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Apr 8, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 8, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 60eb646.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand requested a review from sberyozkin April 9, 2024 09:33
sberyozkin
sberyozkin approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZanHorvat

@sberyozkin sberyozkin merged commit d12aefc into quarkusio:main Apr 9, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

🙈 The PR is closed and the preview is expired.

@gsmet gsmet modified the milestones: 3.10 - main, 3.9.3 Apr 9, 2024
@ZanHorvat ZanHorvat deleted the oidc-client-creator-doc-fix branch May 22, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation triage/backport-3.8
Projects
Quarkus Documentation
Status: Done
Milestone
3.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanHorvat @sberyozkin @gsmet