Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MessageBundle key/file name resolver algorithm #39990

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix MessageBundle key/file name resolver algorithm #39990

merged 1 commit into from
Apr 12, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi requested a review from mkouba April 10, 2024 14:49
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Apr 10, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi
Copy link
Contributor Author

@ercalamar can you give it a try building Quarkus with this PR and let me know if that fixes your issue?

@ercalamar
Copy link

Hi Thanks. I will over the weekend.

mkouba
mkouba reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little comment. Otherwise looks good!

extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/MessageBundleProcessor.java Outdated Show resolved Hide resolved
@gastaldi gastaldi requested a review from mkouba April 12, 2024 12:24
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 12, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 463a411.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 08d36bd into quarkusio:main Apr 12, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 12, 2024
@gsmet gsmet modified the milestones: 3.10.0.CR1, 3.9.4 Apr 17, 2024
@gsmet gsmet modified the milestones: 3.9.4, 3.8.5 May 15, 2024
@gastaldi gastaldi deleted the qute_locale branch May 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/qute The template engine kind/bugfix
Projects
None yet
Milestone
3.8.5
Development

Successfully merging this pull request may close these issues.

MessageBundle naming issue
4 participants
@gastaldi @ercalamar @mkouba @gsmet