-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionalize content in upstream Quarkus repository for the 3.8.next product release #39999
Conditionalize content in upstream Quarkus repository for the 3.8.next product release #39999
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
1e77253
to
ff5b29b
Compare
This comment has been minimized.
This comment has been minimized.
ff5b29b
to
77d7107
Compare
This comment has been minimized.
This comment has been minimized.
77d7107
to
c953567
Compare
This comment has been minimized.
This comment has been minimized.
Hi @rolfedh It is a massive and tricky project, thanks, I've started making suggestions, but then stopped as I thought |
docs/src/main/asciidoc/security-oidc-configuration-properties-reference.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review suggestions, @sberyozkin! Very appreciated!
For each suggestion, I've either updated the content and marked it as resolved, or I've provided a response in a comment. Please would you have at these unresolved ones and if you agree with my comment, mark them as resolved?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Understandable confusion. It's slightly counterintuitive. |
Status for workflow
|
This comment has been minimized.
This comment has been minimized.
6d8e5c8
to
91bdad2
Compare
This comment has been minimized.
This comment has been minimized.
57a8553
to
e12f035
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to +1 until i noticed this touches more than just security docs and remove important info around in writing extensions. see my comments.
de5c046
to
1e19981
Compare
This comment has been minimized.
This comment has been minimized.
…t product release
1e19981
to
3285287
Compare
Status for workflow
|
Thanks @rolfedh |
Fixes #39954