Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change quarkus-webjars-locator relocation message #40280

Merged

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Apr 25, 2024

The message for quarkus-webjars-locator pointing to 3.10 migration guide but this change wasn't part of 3.10 but will be in 3.11.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Can you update the version here too: https://github.com/quarkusio/quarkus/blob/main/relocations/generaterelocations.java#L148 ?

We are using it to regenerate the relocations so it's the reference.

Thanks!

@jedla97 jedla97 force-pushed the fix-webjars-locator-migration-guide branch from 7683d4b to 1622cf9 Compare April 25, 2024 13:55
@jedla97
Copy link
Contributor Author

jedla97 commented Apr 25, 2024

Updated

@jedla97 jedla97 requested a review from gsmet April 25, 2024 13:56
@gsmet gsmet changed the title Change quarkus-webjars-locator realocation message Change quarkus-webjars-locator relocation message Apr 25, 2024
Copy link

quarkus-bot bot commented Apr 25, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1622cf9.

✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself.
You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 1f4b5c0 into quarkusio:main Apr 25, 2024
15 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants