Image resolvers should support both ubi 8 and 9 #40821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
gastaldi
reviewed
May 27, 2024
...va/io/quarkus/container/image/docker/common/deployment/RedHatOpenJDKRuntimeBaseProvider.java
Outdated
Show resolved
Hide resolved
edeandrea
force-pushed
the
enhance-dockerfile-base-information-provider
branch
2 times, most recently
from
b94b469
to
5cb3d06
Compare
This comment has been minimized.
This comment has been minimized.
gastaldi
approved these changes
May 28, 2024
edeandrea
force-pushed
the
enhance-dockerfile-base-information-provider
branch
from
6696e1e
to
a01484d
Compare
edeandrea
force-pushed
the
enhance-dockerfile-base-information-provider
branch
from
e44c2d0
to
40a6704
Compare
Status for workflow
|
gsmet
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UbiMinimalBaseProviderandRedHatOpenJDKRuntimeBaseProvidershould support both ubi 8 and 9 images. This PR adds this capability and additional tests.