Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hibernate-orm/deployment devmode tests to a separate surefire execution #40864

Merged

Conversation

yrodiere
Copy link
Member

In the hope this will reduce the impact of QuarkusDevModeTest metaspace memory leaks.

…ecution

In the hope this will reduce the impact of QuarkusDevModeTest metaspace
memory leaks.
Copy link

quarkus-bot bot commented May 28, 2024

/cc @gsmet (hibernate-orm)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually classify the tests by using the DMT suffix instead of Test, but you'll be maintaining this, so however you prefer :)

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 28, 2024
Copy link

quarkus-bot bot commented May 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7fb9a40.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@yrodiere yrodiere merged commit 720255a into quarkusio:main May 28, 2024
40 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 28, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 28, 2024
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.1 Jun 4, 2024
@yrodiere yrodiere deleted the orm-surefire-devmode-separate-execution branch June 21, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants