Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test scope for dependency quarkus-security-test-utils in reactive routes #40958

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Adding test scope for dependency quarkus-security-test-utils in reactive routes #40958

merged 1 commit into from
Jun 6, 2024

Conversation

HerrDerb
Copy link
Contributor

@HerrDerb HerrDerb commented Jun 4, 2024 •
edited
Loading

Something small I stumbled over.

Test dependency quarkus-security-test-utils was missing test scope

https://github.com/quarkusio/quarkus/blob/main/extensions/reactive-routes/deployment/pom.xml#L70

@HerrDerb HerrDerb changed the title Adding test scope for dependency quarkus-security-test-utils in reactive routing Adding test scope for dependency quarkus-security-test-utils in reactive routes Jun 4, 2024
gsmet
gsmet approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense but I checked things quickly and apparently the scope is inherited anyway.

Can you confirm you didn't see the dependency in your app?

@HerrDerb
Copy link
Contributor Author

HerrDerb commented Jun 5, 2024

@gsmet Yes, can confirm that the dependency is not part of the built extension

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7dcf843.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 20d3c9d into quarkusio:main Jun 6, 2024
23 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/security
Projects
None yet
Milestone
3.12.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@HerrDerb @gsmet @geoand