Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vert.x 4.5.8 and Netty 4.1.110 #41155

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Jun 12, 2024

  • bump Mutiny Bindings to 3.13.0
  • bump Quarkus HTTP to 5.3.0
  • update Netty SSL released substitutions

Netty 4.1.111 causes a problem in gRPC. It seems to be a frame size issue. Need to be investigated.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/netty labels Jun 12, 2024
gsmet
gsmet previously requested changes Jun 12, 2024
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check your IDE settings. A few star imports crawled in.

@geoand geoand dismissed gsmet’s stale review June 12, 2024 12:41

comment addressed

@geoand
Copy link
Contributor

geoand commented Jun 12, 2024

cc @franz1981 who I know wants to try the new AdaptivePoolingAllocator

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member Author

We would need to investigate the gRPC failure. My quick analysis indicates that it's a frame size issue. The response exceeded the default frame size.

@geoand
Copy link
Contributor

geoand commented Jun 13, 2024

Is that reflection test thing that was disabled testing a feature that is really obscure?

@quarkus-bot

This comment has been minimized.

@cescoffier
Copy link
Member Author

Yeah the reflection service from gRPC (which has nothing to do with Java reflection) is a way to discover gRPc services.

However, it might fails because there is something else going on. We need to investigate.

@cescoffier
Copy link
Member Author

@franz1981 @geoand @vietj So, the gRPC issue comes from an incompatibility between grpc java and NEtty 4.1.111. PRevious versions of Netty work :-(. Need to see which commit can causes such a problem.

We may have to stay on 4.1.110 for now.

@cescoffier cescoffier changed the title Update to Vert.x 4.5.8 and Netty 4.1.111 Update to Vert.x 4.5.8 and Netty 4.1.110 Jun 14, 2024
- bump Mutiny Bindings to 3.13.0
- bump Quarkus HTTP to 5.3.0
- update Netty SSL released substitutions
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 14, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 88c2895.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gastaldi
Copy link
Contributor

The commit message seems misleading, given that Netty is no longer updated?

@gsmet
Copy link
Member

gsmet commented Jun 14, 2024

@gastaldi Netty is updated but just to 4.1.110.

@gsmet gsmet merged commit 6a5418f into quarkusio:main Jun 14, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 14, 2024
@gsmet
Copy link
Member

gsmet commented Jun 14, 2024

@cescoffier is it something we want to shoe in 3.12?

@gastaldi
Copy link
Contributor

Ah doh, I missed the Netty bump, nvm

@cescoffier
Copy link
Member Author

@gsmet no :-)

@franz1981
Copy link
Contributor

FYI netty/netty#12919 (comment)

@vietj
Copy link

vietj commented Jun 14, 2024 via email

@franz1981
Copy link
Contributor

@cescoffier so final verdict grpc/grpc-java#11284 (comment)

@vietj
Copy link

vietj commented Jun 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/grpc gRPC area/netty triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants