-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Keycloak version to 25.0.0 #41162
Conversation
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was smooth :)
Status for workflow
|
This PR bumps Keycloak version to 25.0.0 alongside the following changes:
keycloak-adapter-core
from the bom since it is no longer shipped starting from Keycloak 25.0.0nonce
claim is no longer included in the access token, but only in the ID token, https://www.keycloak.org/docs/25.0.0/upgrading/#nonce-claim-is-only-added-to-the-id-token, so I had to fix the Quarkus code expecting it also be included in the access token - in fact it was not really intended to work for the access token, the test where both ID and access tokens were checked to containnonce
was passing by chance due to earlier Keycloak version including it in the access token, but the OIDC spec itself is only concerned aboutnonce
being set in the original ID tokenCC @mposolda