Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-build fails to detect podman: add back detectContainerRuntime() method for backwards compatibility #41164

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jun 12, 2024

Fixup PR #41100 issue #41085

#41100 replaced detectContainerRuntime() with detectContainerRuntime(ContainerRuntime... orderToCheckRuntimes) which makes all callers of detectContainerRuntime() fail with NoSuchMethodException unless they are recompiled.

detectContainerRuntime() method for backwards compatibility
Copy link

quarkus-bot bot commented Jun 12, 2024

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 12, 2024

If this could please be backported to 3.12

@edeandrea
Copy link
Contributor

I don't have permissions to label things, but this will need the triage/backport label

geoand added a commit to geoand/quarkus that referenced this pull request Jun 12, 2024
This change is done as a response to quarkusio#41164, although it might not
fix the issue
Copy link

quarkus-bot bot commented Jun 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7c176b6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

⚙️ JVM Tests - JDK 21

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxConnectionMetricsTest.testConnectionMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

geoand added a commit to geoand/quarkus that referenced this pull request Jun 13, 2024
This change is done as a response to quarkusio#41164, although it might not
fix the issue
@gsmet gsmet merged commit 9d752ab into quarkusio:main Jun 14, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 14, 2024
@gsmet
Copy link
Member

gsmet commented Jun 14, 2024

Thanks @ppalaga , I'll make sure it's in 3.12.

@gsmet gsmet changed the title Fixup #41085 Docker-build fails to detect podman: add back detectContainerRuntime() method for backwards compatibility Docker-build fails to detect podman: add back detectContainerRuntime() method for backwards compatibility Jun 14, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.0 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants