Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler: add custom thread factory to use a specific thread name #41242

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Scheduler: add custom thread factory to use a specific thread name #41242

merged 1 commit into from
Jun 17, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 17, 2024

  • also fix the CronTrigger "fired" log TRACE message

@mkouba
Scheduler: add custom thread factory to use a specific thread name
e3fa7f1 
- also fix the CronTrigger "fired" log TRACE message
@mkouba mkouba requested a review from manovotn June 17, 2024 08:05
@mkouba
Copy link
Contributor Author

mkouba commented Jun 17, 2024

Previously, the Executors.defaultThreadFactory() was used, so the thread name was something like pool-8-thread-1.

manovotn
manovotn approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 17, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e3fa7f1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit dced341 into quarkusio:main Jun 17, 2024
24 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 17, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.0 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/scheduler
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @manovotn @gsmet