Initial gRPC CLI #41249

alesj · 2024-06-17T11:05:43Z

Simple gcurl-like CLI -- currently supporting gRPC list, describe and invoke.

iocanel

PR looks good to me.

iocanel · 2024-06-18T14:51:16Z

It's not clear to me why CI barfs.

alesj · 2024-06-19T07:10:31Z

@gsmet any idea? ^

cescoffier

We need to verify if it can be built from scratch.

Also, Some tests would be useful.

cescoffier · 2024-06-24T06:14:17Z

extensions/grpc/cli/src/main/java/io/quarkus/grpc/cli/GrpcCommand.java

+import picocli.CommandLine.Spec;
+
+@TopCommand
+@Command(name = "grpc", sortOptions = false, header = "grpc CLI", subcommands = {


Why CLI in the header?

So just dropping the CLI?

cescoffier · 2024-06-24T06:14:36Z

extensions/grpc/cli/src/main/java/io/quarkus/grpc/cli/GrpcCommand.java

+    @Spec
+    protected CommandSpec spec;
+
+    @CommandLine.Option(names = { "-h", "--help" }, usageHelp = true, description = "Display this help message.")


Isn't this generated by picocli automatically?

Hmmm, no idea -- copied this from one of the existing CLI commands ...
@iocanel ^ ?

@iocanel can this be dropped? ^

I think that it can be possibly dropped.

cescoffier · 2024-06-24T06:17:43Z

extensions/grpc/cli/src/main/resources/application.properties

+quarkus.log.level=INFO
+quarkus.banner.enabled=false
+quarkus.package.jar.type=uber-jar
+quarkus.package.jar.add-runner-suffix=false


This won't work I believe.
When building Quarkus from scratch, you won't find the plugin, because the plugin is built.

In another case, I had to switch to the assembly maven plugin (would love to switch back to the Quarkus plugin).

Hmm, yeah, this could be a problem ... since my copied example was from Quarkiverse, hence made it more easy.
Any ideas / suggestions what can be done?

Yes :-) I'm going to push a PR today that does this.

is there a reason we do uberjar here? why not just reuse users most likely already downloaded deps for this cli?

@maxandersen seems like Uber-jar is the way to distribute self-contained commands. At least that's what I got from the doc and when I tried the "fast-jar" approach, it did not work (and anyway, fast jar would need quarkus before quarkus)

yeah okey - if the actual cli is a quarkus app and not "just" a java app you need it. It would be interesting if we had a way to make a jar that has only the classes that need changing and rest could just be fetched using dependencies.

hmm - even uber-jar would need quarkus before quarkus would it not?

Using Quarkus for these commands works, but yes it might be overkill.

By using the assembly plugin it works because it waits for all dependencies to be built before building that fat jar. Having a plugin dependency is slightly more complicated and fail in all my attempts from scratch. Funny, I had the same issue more than 10 years ago where I had to have profiles to build the plugin and then the modules using the plugin.

We should be able to build the Maven plugin right after core-deployment to make it available for other extensions.

alesj · 2024-06-24T07:58:11Z

We need to verify if it can be built from scratch.

Scratch? Wdym?

Also, Some tests would be useful.

Yeah ... is there some existing example of it?
So I don't re-discover water :-)

cescoffier · 2024-07-01T08:24:22Z

Look at #41418

alesj · 2024-07-17T15:40:47Z

@cescoffier OK, added assembly + test(s)

I don't know how we can end up with duplicates in the JSON descriptor but let's make sure it doesn't affect our build.

It is not an extension so it should not depend on extensions.

quarkus-bot · 2024-08-11T13:51:25Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 5426aaa.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-08-11T18:47:51Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 5426aaa.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

I think the comments were addressed. I will merge it to 3.14 and we can improve on it later.

gsmet · 2024-08-12T09:43:20Z

I think we will need to take a big step back as to what is an extension or not in the gRPC stuff as we had numerous issues with that and, while we were able to work around them, some are still around.

I will merge it for 3.14 as I think it's an interesting addition and we can improve on it.

github-actions · 2024-08-12T09:44:19Z

🙈 The PR is closed and the preview is expired.

alesj requested a review from cescoffier June 17, 2024 11:05

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/grpc gRPC labels Jun 17, 2024

alesj requested a review from iocanel June 17, 2024 11:06