Bump Microsoft SQL Server JDBC driver to 12.6.3 #41256

sschu · 2024-06-17T12:24:21Z

gsmet

Thanks! Let's see what CI has to say.

sschu · 2024-06-18T06:13:41Z

Something wrong in the native image build. I'll have a look...

sschu · 2024-06-18T07:45:15Z

I have to admit, I am pretty lost. I can reproduce the error locally but the code the parser complains about basically hasn't been touched for years. I don't really see a difference between 12.6.1 and 12.6.2 that sounds like the error message.

gsmet · 2024-06-18T16:17:10Z

Error is:

Fatal error: com.oracle.graal.pointsto.util.AnalysisError$ParsingError: Error encountered while parsing com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatementBatch(SQLServerPreparedStatement.java:3024) 
Parsing context:
   at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtBatchExecCmd.doExecute(SQLServerPreparedStatement.java:3012)
   at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7748)
   at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeReconnectCommand(SQLServerConnection.java:4495)
   at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectionCommand(SQLServerConnection.java:4539)
   at com.microsoft.sqlserver.jdbc.SQLServerConnection.setAutoCommit(SQLServerConnection.java:4684)
   at root method.(Unknown Source)

	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisError.parsingError(AnalysisError.java:149)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.createFlowsGraph(MethodTypeFlow.java:184)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.ensureFlowsGraphCreated(MethodTypeFlow.java:153)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.getOrCreateMethodFlowsGraphInfo(MethodTypeFlow.java:111)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.typestate.DefaultSpecialInvokeTypeFlow.lambda$onObservedUpdate$0(DefaultSpecialInvokeTypeFlow.java:88)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.LightImmutableCollection.forEach(LightImmutableCollection.java:90)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.typestate.DefaultSpecialInvokeTypeFlow.onObservedUpdate(DefaultSpecialInvokeTypeFlow.java:87)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.TypeFlow.update(TypeFlow.java:620)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.PointsToAnalysis$1.run(PointsToAnalysis.java:491)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.executeCommand(CompletionExecutor.java:187)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.lambda$executeService$0(CompletionExecutor.java:171)
	at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1423)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
Caused by: com.oracle.graal.pointsto.util.AnalysisError: parsing had failed in another thread
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisError.shouldNotReachHere(AnalysisError.java:173)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.meta.AnalysisMethod.ensureGraphParsedHelper(AnalysisMethod.java:871)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.meta.AnalysisMethod.ensureGraphParsed(AnalysisMethod.java:843)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.phases.InlineBeforeAnalysisGraphDecoder.lookupEncodedGraph(InlineBeforeAnalysisGraphDecoder.java:198)
	at jdk.internal.vm.compiler/org.graalvm.compiler.replacements.PEGraphDecoder.doInline(PEGraphDecoder.java:1211)
	at jdk.internal.vm.compiler/org.graalvm.compiler.replacements.PEGraphDecoder.tryInline(PEGraphDecoder.java:1194)
	at jdk.internal.vm.compiler/org.graalvm.compiler.replacements.PEGraphDecoder.trySimplifyInvoke(PEGraphDecoder.java:1049)
	at jdk.internal.vm.compiler/org.graalvm.compiler.replacements.PEGraphDecoder.handleInvokeWithCallTarget(PEGraphDecoder.java:1001)
	at jdk.internal.vm.compiler/org.graalvm.compiler.replacements.PEGraphDecoder.handleInvoke(PEGraphDecoder.java:987)
	at jdk.internal.vm.compiler/org.graalvm.compiler.nodes.GraphDecoder.processNextNode(GraphDecoder.java:921)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.phases.InlineBeforeAnalysisGraphDecoder.processNextNode(InlineBeforeAnalysisGraphDecoder.java:378)
	at jdk.internal.vm.compiler/org.graalvm.compiler.nodes.GraphDecoder.decode(GraphDecoder.java:650)
	at jdk.internal.vm.compiler/org.graalvm.compiler.replacements.PEGraphDecoder.decode(PEGraphDecoder.java:892)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.phases.InlineBeforeAnalysis.decodeGraph(InlineBeforeAnalysis.java:76)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlowBuilder.parse(MethodTypeFlowBuilder.java:195)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlowBuilder.apply(MethodTypeFlowBuilder.java:621)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.createFlowsGraph(MethodTypeFlow.java:167)
------------------------------------------------------------------------------------------------------------------------
                       9.1s (12.5% of total time) in 102 GCs | Peak RSS: 2.88GB | CPU load: 3.81
========================================================================================================================
Finished generating 'quarkus-integration-test-jpa-mssql-999-SNAPSHOT-runner' in 1m 11s.
	... 15 more
Caused by: com.oracle.graal.pointsto.constraints.UnresolvedElementException: Discovered unresolved method during parsing: com.microsoft.sqlserver.jdbc.SQLServerSecurityUtility.decryptSymmetricKey(com.microsoft.sqlserver.jdbc.CryptoMetadata, com.microsoft.sqlserver.jdbc.SQLServerConnection, com.microsoft.sqlserver.jdbc.SQLServerStatement). This error is reported at image build time because class com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement is registered for linking at image build time by command line and command line.
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase$SharedBytecodeParser.reportUnresolvedElement(SharedGraphBuilderPhase.java:550)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase$SharedBytecodeParser.reportUnresolvedElement(SharedGraphBuilderPhase.java:544)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase$SharedBytecodeParser.handleUnresolvedMethod(SharedGraphBuilderPhase.java:471)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase$SharedBytecodeParser.handleUnresolvedInvoke(SharedGraphBuilderPhase.java:368)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.genInvokeStatic(BytecodeParser.java:1693)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.genInvokeStatic(BytecodeParser.java:1672)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.processBytecode(BytecodeParser.java:5416)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.iterateBytecodesForBlock(BytecodeParser.java:3426)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase$SharedBytecodeParser.iterateBytecodesForBlock(SharedGraphBuilderPhase.java:743)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.handleBytecodeBlock(BytecodeParser.java:3386)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.processBlock(BytecodeParser.java:3228)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.build(BytecodeParser.java:1137)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase$SharedBytecodeParser.build(SharedGraphBuilderPhase.java:162)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.BytecodeParser.buildRootMethod(BytecodeParser.java:1029)
	at jdk.internal.vm.compiler/org.graalvm.compiler.java.GraphBuilderPhase$Instance.run(GraphBuilderPhase.java:101)
	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.phases.SharedGraphBuilderPhase.run(SharedGraphBuilderPhase.java:116)
	at jdk.internal.vm.compiler/org.graalvm.compiler.phases.Phase.run(Phase.java:49)
	at jdk.internal.vm.compiler/org.graalvm.compiler.phases.BasePhase.apply(BasePhase.java:434)
	at jdk.internal.vm.compiler/org.graalvm.compiler.phases.Phase.apply(Phase.java:42)
	at jdk.internal.vm.compiler/org.graalvm.compiler.phases.Phase.apply(Phase.java:38)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.AnalysisParsedGraph.parseBytecode(AnalysisParsedGraph.java:146)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.meta.AnalysisMethod.parseGraph(AnalysisMethod.java:895)
	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.meta.AnalysisMethod.ensureGraphParsedHelper(AnalysisMethod.java:860)

https://github.com/quarkusio/quarkus/actions/runs/9547746401/job/26328201377

gsmet · 2024-06-18T16:17:44Z

@zakkak do you have any hint on what's going on here? The error is not exactly clear?

zakkak · 2024-06-18T22:26:24Z

Indeed, the error message indicates that com.microsoft.sqlserver.jdbc.SQLServerSecurityUtility.decryptSymmetricKey(com.microsoft.sqlserver.jdbc.CryptoMetadata, com.microsoft.sqlserver.jdbc.SQLServerConnection, com.microsoft.sqlserver.jdbc.SQLServerStatement) can't be resolved.

Looking at https://github.com/microsoft/mssql-jdbc/blob/17caf22234e632407499ad4e5a234c9da2de5aef/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java#L228 the method is present in the source code and I also see it in the decompiled class file from the maven artifact.

I tried attaching the debugger to see the root cause (and why it's not printed) and the issue is caused by:

java.lang.ClassNotFoundException: com.azure.core.credential.TokenCredential

zakkak · 2024-06-18T23:36:20Z

For future reference, to debug this I set a breakpoint at https://github.com/graalvm/mandrel/blob/08389e1be8f9588c03ffa34a7820fab22fb3dcf1/substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/phases/SharedGraphBuilderPhase.java#L248 and run:

./mvnw -Dnative -pl integration-tests/jpa-mssql/ -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests clean package -Dquarkus.native.container-runtime=podman -Dquarkus.native.debug-build-process

Then I attach my IDE/Debugger to port 5005, when the breakpoint is hit all we need is to inspect the cause of the exception.

gsmet · 2024-06-19T07:24:48Z

@zakkak thanks! And thanks for creating an issue on the GraalVM side to improve the error message.

Signed-off-by: Sebastian Schuster <sebastian.schuster@bosch.io>

sschu · 2024-06-27T14:02:48Z

@zakkak The reference to TokenCredential was a good hint, I was able to find the code referencing the optional dependency and substituting it out and it worked. In the meantime, the same issue was reported at the mssql-jdbc driver (see microsoft/mssql-jdbc#2453) and released (see https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3). So this should work without any modifications now with 12.6.3. I hope the CI agrees.
@gsmet FYI.

quarkus-bot · 2024-06-27T20:19:28Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit c704521.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

gsmet · 2024-06-27T20:25:44Z

Thanks!

quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jun 17, 2024

sschu force-pushed the 41255_bump_mssql_jdbc_driver_to_12.6.2 branch from c1c2c1b to ac4b6a8 Compare June 17, 2024 12:33

gsmet changed the title ~~41255 bump mssql-jdbc to 12.6.2~~ Bump Microsoft SQL Server JDBC driver to 12.6.2 Jun 17, 2024

gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2024

gsmet approved these changes Jun 17, 2024

View reviewed changes

zakkak mentioned this pull request Jun 18, 2024

[GR-46526] Preserve LinkageErrors and re-throw them at run-time. oracle/graal#6753

Closed

zakkak mentioned this pull request Jun 18, 2024

Cryptic parsing error messages with --link-at-build-time and incomplete classpath oracle/graal#6253

Open

41255 bump mssql-jdbc to 12.6.3

c704521

Signed-off-by: Sebastian Schuster <sebastian.schuster@bosch.io>

sschu force-pushed the 41255_bump_mssql_jdbc_driver_to_12.6.2 branch from ac4b6a8 to c704521 Compare June 27, 2024 13:57

sschu changed the title ~~Bump Microsoft SQL Server JDBC driver to 12.6.2~~ Bump Microsoft SQL Server JDBC driver to 12.6.3 Jun 27, 2024

quarkus-bot bot added the triage/flaky-test label Jun 27, 2024

gsmet merged commit f3acd86 into quarkusio:main Jun 27, 2024
52 checks passed

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 27, 2024

quarkus-bot bot added this to the 3.13 - main milestone Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Microsoft SQL Server JDBC driver to 12.6.3 #41256

Bump Microsoft SQL Server JDBC driver to 12.6.3 #41256

sschu commented Jun 17, 2024

gsmet left a comment

sschu commented Jun 18, 2024

sschu commented Jun 18, 2024 •

edited

Loading

gsmet commented Jun 18, 2024

gsmet commented Jun 18, 2024

zakkak commented Jun 18, 2024 •

edited

Loading

zakkak commented Jun 18, 2024 •

edited

Loading

gsmet commented Jun 19, 2024

sschu commented Jun 27, 2024

quarkus-bot bot commented Jun 27, 2024 •

edited by github-actions bot

Loading

gsmet commented Jun 27, 2024

Bump Microsoft SQL Server JDBC driver to 12.6.3 #41256

Bump Microsoft SQL Server JDBC driver to 12.6.3 #41256

Conversation

sschu commented Jun 17, 2024

gsmet left a comment

Choose a reason for hiding this comment

sschu commented Jun 18, 2024

sschu commented Jun 18, 2024 • edited Loading

gsmet commented Jun 18, 2024

gsmet commented Jun 18, 2024

zakkak commented Jun 18, 2024 • edited Loading

zakkak commented Jun 18, 2024 • edited Loading

gsmet commented Jun 19, 2024

sschu commented Jun 27, 2024

quarkus-bot bot commented Jun 27, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

gsmet commented Jun 27, 2024

sschu commented Jun 18, 2024 •

edited

Loading

zakkak commented Jun 18, 2024 •

edited

Loading

zakkak commented Jun 18, 2024 •

edited

Loading

quarkus-bot bot commented Jun 27, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`