Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to maven 3.9.8 #41260

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Update to maven 3.9.8 #41260

merged 1 commit into from
Jun 18, 2024

Conversation

manofthepeace
Copy link
Contributor

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 17, 2024
gsmet
gsmet approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks, I was waiting for this version so that we could align mvnd and the wrapper with the latest!

@robp94
Copy link
Contributor

robp94 commented Jun 18, 2024

Maven 3.9.8 seems to work fine for our quarkus 3.8.5 projects but the new mvnd version fails

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.8.5:generate-code-tests (default) on project attribute-service: Execution default of goal io.quarkus:quarkus-maven-plugin:3.8.5:generate-code-tests failed: A required class was missing while executing io.quarkus:quarkus-maven-plugin:3.8.5:generate-code-tests: org/jline/reader/LineReader
[ERROR] -----------------------------------------------------
[ERROR] realm =    extension>io.quarkus:quarkus-maven-plugin:3.8.5
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/.m2/repository/io/quarkus/quarkus-maven-plugin/3.8.5/quarkus-maven-plugin-3.8.5.jar
...

@gsmet gsmet merged commit f285302 into quarkusio:main Jun 18, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 18, 2024
@gsmet
Copy link
Member

gsmet commented Jun 18, 2024

@robp94 the mvnd issue will be fixed by smallrye/smallrye-beanbag#130

We will update to SmallRye BeanBag 1.5.2 very soon and backport the change.

@manofthepeace manofthepeace deleted the mvn-3.9.8 branch June 18, 2024 13:12
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@manofthepeace @robp94 @gsmet