Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM Quarkus Dashboard #41264

Merged
merged 2 commits into from
Sep 30, 2024
Merged

LGTM Quarkus Dashboard #41264

merged 2 commits into from
Sep 30, 2024

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Jun 17, 2024 •
edited
Loading

Fix #40933: LGTM Quarkus Dashboard
Fix #41944

cc @brunobat @alesj

  • Adds Quarkus Micrometer Dashboard including JVM, HTTP, JDBC and other stats provided by Micrometer.
  • I just need some guidance on the TODO how to get those values properly

image

@melloware melloware marked this pull request as ready for review June 18, 2024 13:06
@melloware
Copy link
Contributor Author

OK I resolved that issue

@melloware melloware force-pushed the lgtm-40933 branch 2 times, most recently from 90c1a11 to 1c41146 Compare July 3, 2024 21:25
@gastaldi gastaldi requested a review from brunobat July 5, 2024 11:27
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@melloware melloware force-pushed the lgtm-40933 branch 2 times, most recently from f312998 to 20135bd Compare July 18, 2024 11:49
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Contributor

@melloware, back from vacations.
I wonder if we could deploy this dashboard on the grafana repository, as well.
Will need some time to review this.

@melloware
Copy link
Contributor Author

yeah i put this here because i wasn't sure if we wanted to get feedback from other Quarkus Users if there was anything missing they want on there?

@melloware
Copy link
Contributor Author

i also think the colors and times for uptimes might need to be tweaked but i thought it was a pretty good first stab 😄

@melloware melloware force-pushed the lgtm-40933 branch 3 times, most recently from bee696e to 1b6fca0 Compare August 20, 2024 12:20
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
brunobat
brunobat requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure the app will return data for all the dashboard components and understand why they lack data or is we need to instrument something else...
I've used this app, which is basically the Quick start"https://github.com/brunobat/quarkus-lab/blob/main/micrometer-lgtm/pom.xml
But with it, out of the box, the dashboard looks like this:
Screenshot 2024-09-17 at 11 36 01
Screenshot 2024-09-17 at 11 36 16

@brunobat
Copy link
Contributor

Also, we should pull up the HTTP parts.

@melloware
Copy link
Contributor Author

Yes this was more of an idea, and we need to check the dashboard for startup time those eventually fill in if you leave the app running.

@melloware melloware force-pushed the lgtm-40933 branch 2 times, most recently from e4a6c25 to 280f66d Compare September 17, 2024 11:54
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core labels Sep 17, 2024
@geoand geoand added area/tracing release/noteworthy-feature and removed area/reactive-messaging area/oidc area/kafka area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/graphql area/rest area/keycloak area/docstyle issues related for manual docstyle review labels Sep 30, 2024
@gastaldi
Copy link
Contributor

If anyone could point me to some documentation on how to enable this, it would help :)

@edeandrea
Copy link
Contributor

https://quarkus.io/guides/observability-devservices-lgtm ?

@gastaldi
Copy link
Contributor

I followed the guide above and had trouble finding the dashboards on the main page. After some digging, I navigated to http://localhost:43915/dashboards and found them there. Can we star them so they show up on the main page? I think that would be a much better experience.

On a separate note, I noticed that quarkus create app --extension=rest-jackson,quarkus-observability-devservices-lgtm fails with

[ERROR] ❗  Cannot find a dependency matching 'quarkus-observability-devservices-lgtm', maybe a typo?
[ERROR] ❗  Unable to create project: Failed to create project because of invalid extensions

gastaldi
gastaldi reviewed Sep 30, 2024
View reviewed changes
...ices/testcontainers/src/main/java/io/quarkus/observability/testcontainers/LgtmContainer.java
scrape_configs:
- job_name: '%s'
metrics_path: '%s%s'
scrape_interval: 10s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably reduce the scrape interval to 3s for faster updates

gastaldi
gastaldi approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (no pun intended) :)

@melloware
Copy link
Contributor Author

Thanks for testing @gastaldi

@geoand geoand merged commit 79099ce into quarkusio:main Sep 30, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 30, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 30, 2024
@melloware melloware deleted the lgtm-40933 branch September 30, 2024 13:59
@brunobat brunobat mentioned this pull request Sep 30, 2024
Open
@brunobat
Copy link
Contributor

brunobat commented Sep 30, 2024 •
edited
Loading

Created issue with follow up work: #43599

@alesj
Copy link
Contributor

alesj commented Sep 30, 2024

Nice work all!

@Inithron Inithron mentioned this pull request Oct 12, 2024
Closed
@adriens
Copy link

adriens commented Oct 30, 2024

Would you share a blog post or video where you show the whole thing going alive ?

@melloware
Copy link
Contributor Author

@adriens just follow this guide and run mvn quarkus:dev and see it for yourself in action? https://quarkus.io/guides/observability-devservices-lgtm

@adriens
Copy link

adriens commented Oct 31, 2024

@adriens just follow this guide and run mvn quarkus:dev and see it for yourself in action? https://quarkus.io/guides/observability-devservices-lgtm

Thanks a lot @melloware , I'll prepare a dedicated internal issue for my team and will let you know on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alesj alesj alesj left review comments

@brunobat brunobat brunobat approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/metrics area/tracing kind/enhancement New feature or request release/noteworthy-feature
Projects
Quarkus Roadmap/Planning
Status: Done
Milestone
3.16.0.CR1
7 participants
@melloware @brunobat @edeandrea @geoand @gastaldi @alesj @adriens