Added tests for KubernetesClient serialization/deserialization #41274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should ensure that (de)serialization works as expected both in JVM and Native modes. Signed-off-by: Marc Nuri <marc@marcnuri.com>
Status for workflow
|
galderz
reviewed
Jun 19, 2024
...-client/src/test/java/io/quarkus/it/kubernetes/client/KubernetesClientSerializationTest.java
Show resolved
Hide resolved
galderz
reviewed
Jun 19, 2024
| .build()) | ||
| .create(); | ||
| // JSON data is retrieved from the mock server | ||
| when() |
There was a problem hiding this comment.
Is this really verifying that the JSON shape is the expected one and not the one with all the empty objects/arrays? #39934 (comment)
There was a problem hiding this comment.
AFAIK, it should.
In any case, if you want to verify manually you can change line 113 from
.log().ifValidationFails(LogDetail.BODY);to
.log().body();We can also add another assertion to verify that the response body doesn't actually contain the word overhead:
.body(not(containsString("overhead"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should ensure that (de)serialization works as expected both in JVM and Native modes.
Relates to #39934
/cc @galderz