Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade to Hibernate ORM 7 #41310

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Commits on Nov 14, 2024

  1. Map all relevant attributes in JPA XML mapping tests

    First because there's no reason not to (we're not testing the behavior
    for unmapped attributes), and second to work around a bug in Hibernate
    ORM 7.0 alphas/betas: https://hibernate.atlassian.net/browse/HHH-18662
    yrodiere committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5692268 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    b1f8fec View commit details
    Browse the repository at this point in the history
  2. Make QuarkusPersistenceUnitDescriptor available to FastBootHibernateP…

    …ersistenceProvider
    
    Not strictly necessary, but doesn't hurt and might allow more changes in
    the next commits.
    yrodiere committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8d0db21 View commit details
    Browse the repository at this point in the history
  3. Disallow CDI beans impacting metadata creation

    Because:
    
    1. We currently disallow this for identifier generators only
       through a custom initializer for the identifier generator
       factory service, but that service is disappearing in Hibernate
       ORM 7.0.0.Beta1, leaving us only the setting `hibernate.cdi.extensions`.
       to disallow CDI for identifier generators -- and anything else
       that impacts metadata creation.
    2. This is needed for quarkusio#40897,
       which will move more of metadata creation to build time -- where CDI
       is just not available.
    3. Implementations of affected components needing access to CDI at
       runtime (so not during metadata creation) can still do so by
       calling `Arc.container()` to retrieve the relevant beans.
    yrodiere committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    927e697 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b162dc5 View commit details
    Browse the repository at this point in the history
  5. Make Hibernate ORM and jdbc-derby extensions work without any other r…

    …equired dependencies
    
    With Derby moving to hibernate-community-dialects, Quarkus will need to
    add this dependency automatically.
    yrodiere committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    96a5754 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    52ac3a9 View commit details
    Browse the repository at this point in the history