Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OIDC token retrieval under concurrency test flakiness #41340

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix OIDC token retrieval under concurrency test flakiness #41340

merged 1 commit into from
Jun 20, 2024

Conversation

Dougniel
Copy link
Contributor

@Dougniel Dougniel commented Jun 20, 2024 •
edited
Loading

improve test reliability at the expense of test time

fix #41298

@Dougniel
Fix odic token retrieval under concurrency test flakiness
2e887f5 
improve test reliability et the expense of test time

fix quarkusio#41298
sberyozkin
sberyozkin approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dougniel

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 20, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2e887f5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit cdc1637 into quarkusio:main Jun 20, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 20, 2024
@Dougniel Dougniel deleted the OidcClient-concurrency-test-flaky-41298 branch June 21, 2024 06:08
@gsmet gsmet changed the title Fix odic token retrieval under concurrency test flakiness Fix OIDC token retrieval under concurrency test flakiness Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/oidc kind/bugfix
Projects
None yet
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.

OidcClient concurrency test is a bit flaky
3 participants
@Dougniel @sberyozkin @gsmet