Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quartz fix to use correct async constant #41370

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Quartz fix to use correct async constant #41370

merged 1 commit into from
Jun 24, 2024

Conversation

melloware
Copy link
Contributor

Fix #41361

@gsmet gsmet requested a review from mkouba June 24, 2024 07:37
mkouba
mkouba approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I think that we should add a test and verify somehow the job data used. However, you can't really use the API to access the job data now so we'll need to address this problem in a follow-up PR.

@mkouba mkouba added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Jun 24, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 24, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 990df51.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 1756daf into quarkusio:main Jun 24, 2024
20 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 24, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 24, 2024
mkouba added a commit to mkouba/quarkus that referenced this pull request Jun 24, 2024
@mkouba
Quartz: add a test for programmatic job metadata
985f582 
- this is a follow-up of quarkusio#41370
@mkouba mkouba mentioned this pull request Jun 24, 2024
Merged
@melloware melloware deleted the quartz-41361 branch June 24, 2024 11:17
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jun 26, 2024
@mkouba @gsmet
Quartz: add a test for programmatic job metadata
c3e29ce 
- this is a follow-up of quarkusio#41370

(cherry picked from commit 985f582)
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Jul 31, 2024
@mkouba @holly-cummins
Quartz: add a test for programmatic job metadata
7fdefdc 
- this is a follow-up of quarkusio#41370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

@jacopo-cavallarin jacopo-cavallarin jacopo-cavallarin approved these changes

Assignees
No one assigned
Labels
area/scheduler kind/bugfix
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.

quarkus-quartz: programmatic scheduling of async tasks with jdbc-cmt breaks application startup
4 participants
@melloware @mkouba @jacopo-cavallarin @gsmet