Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Register java.sql.*isClosed methods for reflection" #41581

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jul 1, 2024

This reverts commit 8b90462.

The need for these additional registrations has been handled in upstream GraalVM with oracle/graal#9184 so they are no longer needed.

Closes #41283

This reverts commit 8b90462.

The need for these additional registrations has been handled in upstream
GraalVM with oracle/graal#9184 so they are no
longer needed.

Closes quarkusio#41283
@zakkak zakkak added this to the 3.13 - main milestone Jul 1, 2024
@zakkak zakkak requested a review from gsmet July 1, 2024 11:43
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 1, 2024
Copy link

quarkus-bot bot commented Jul 1, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d1a25d8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

@geoand geoand merged commit 1623bc9 into quarkusio:main Jul 1, 2024
42 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 1, 2024
@zakkak zakkak deleted the 2024-07-01-revert-41257 branch July 1, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods accessed reflectively starting with GraalVM for JDK 23+26
3 participants