Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: extend the @EngineConfiguration support to ParserHook #41690

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 4, 2024

Also introduce ValidationParserHookBuildItem that can be used to hook into the parser logic during validation at
build time.

This comment was marked as outdated.

@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Jul 4, 2024
* <p>
* Validation parser hooks are never used at runtime.
*/
public final class ValidationParserHookBuildItem extends MultiBuildItem {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ia3andy This one will be needed to implement quarkiverse/quarkus-qute-web#96.

@mkouba mkouba requested review from gastaldi and ia3andy July 4, 2024 13:07
@ia3andy
Copy link
Contributor

ia3andy commented Jul 4, 2024

Thanks @mkouba

This comment has been minimized.

@mkouba mkouba force-pushed the qute-parser-hook-engine-config branch from 811534a to 7999e72 Compare July 4, 2024 13:19
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, but LGTM

This comment has been minimized.

@mkouba mkouba force-pushed the qute-parser-hook-engine-config branch from 7999e72 to e17d6e4 Compare July 4, 2024 14:15
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 4, 2024
mkouba and others added 2 commits July 4, 2024 16:27
Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
- that can be used to hook into the parser logic during validation at
build time
@mkouba mkouba force-pushed the qute-parser-hook-engine-config branch from 080357a to 69538fc Compare July 4, 2024 14:27
Copy link

quarkus-bot bot commented Jul 4, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 69538fc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jul 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 69538fc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.InputCollectionOutputCollectionLambdaTest.requestHandler_InputCollectionInputPerson_OutputCollectionOutputPerson - History

  • 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Fred"] Actual: <[{outputname=Chris}]> - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Fred"]
  Actual: <[{outputname=Chris}]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

⚙️ JVM Tests - JDK 21

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.InputCollectionOutputCollectionLambdaTest.requestHandler_InputCollectionInputPerson_OutputCollectionOutputPerson - History

  • 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Fred"] Actual: <[{outputname=Chris}]> - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Fred"]
  Actual: <[{outputname=Chris}]>

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)

@gastaldi gastaldi merged commit 4e36684 into quarkusio:main Jul 5, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 5, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants