-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qute: extend the @EngineConfiguration support to ParserHook #41690
Qute: extend the @EngineConfiguration support to ParserHook #41690
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
* <p> | ||
* Validation parser hooks are never used at runtime. | ||
*/ | ||
public final class ValidationParserHookBuildItem extends MultiBuildItem { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ia3andy This one will be needed to implement quarkiverse/quarkus-qute-web#96.
Thanks @mkouba |
This comment has been minimized.
This comment has been minimized.
811534a
to
7999e72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, but LGTM
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
Outdated
Show resolved
Hide resolved
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
7999e72
to
e17d6e4
Compare
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
Show resolved
Hide resolved
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
Outdated
Show resolved
Hide resolved
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteProcessor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
- that can be used to hook into the parser logic during validation at build time
080357a
to
69538fc
Compare
Status for workflow
|
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
Also introduce
ValidationParserHookBuildItem
that can be used to hook into the parser logic during validation atbuild time.