Fix dev service always restarting on named datasource configuration change

[Malandril]

When a named datasource is used, quarkus tries to check if a some of the cachedProperties have changed to know if it needs to restart the datasource, the cachedProperties stores the properties with and without quotes.
This causes the change check to always be triggered, because when it will compare with the actual microprofile property only one version will exist, either the quoted version, or the unquoted version.
For example with the given property:

quarkus.datasource."named".db-kind=mariadb

cachedProperties will cache the following entries as set by setDataSourceProperties:

quarkus.datasource."named".db-kind=mariadb
quarkus.datasource.named.db-kind=mariadb

And when it will try to check the difference only the quarkus.datasource."named".db-kind=mariadb will be present and so the restart will be triggered.

This PR uses gets a map of the datasource configs which will be used as cache to verify if values have changed.

The drawback of this is that any change in the quarkus.datasource properties triggers a restart, which i think is still better than having a non consistent behaviour because of quotes.

Bug Reproducer here that i used to test this PR.

[gsmet]

Thanks for the PR! That's indeed an annoying issue.

TBH, I'm not entirely sure why we store the two versions in cachedProperties. Maybe to avoid triggering a reload if only the quoting changed. But yeah, breaking the common case for it doesn't make a lot of sense.

I wonder if we could find a better way to do that as it looks like a (useful!) hack on top a hack.

/cc @radcortez @yrodiere

[radcortez]

I'm not sure why we need to have both versions,but apparently there was another issue: See #26815.

[Malandril]

The last commit actually seems to break the build on the pipelines.

In the jpa-postgresql integration test.
A java.util.NoSuchElementException: SRCFG00011: Could not expand value postgres.url in property quarkus.datasource.jdbc.url

As apparently when creating the cached properties, the postgres.url is not available.
This does not happen when i run the test myself.

[yrodiere]

SmallRyeConfig#getOptionalValues seems promising, but I think we got carried away here... see comments below.

[yrodiere]

Thanks, the approach looks good. Some details need our attention though; see comments below.

In particular we'll need @radcortez opinion on that exception.

[yrodiere]

Thanks a lot for your patience, I know it's been a rough ride but it's looking good in the end.

I think the last remaining piece is handling of two runtime properties... see below.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d9b4534.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[Malandril]

Thanks for the review and the help @yrodiere @radcortez

[radcortez]

Thanks for the review and the help @yrodiere @radcortez

No. Thank you for your patience :)

[yrodiere]

Merged, thanks a lot!

[yrodiere]

@gsmet Marking for backport on 3.8 as I think the final implementation would apply cleanly, and the problem looks like something that would impair development significantly.