Suppress unused warning in RestClientMetricsFilter #41755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @brunobat (micrometer), @ebullient (micrometer) |
ebullient
approved these changes
Jul 8, 2024
geoand
added
the
triage/waiting-for-ci
Status for workflow
|
gsmet
approved these changes
Jul 8, 2024
gsmet
reviewed
Jul 8, 2024
| @@ -21,6 +21,7 @@ | |||
| */ | |||
| @Unremovable | |||
| @Provider | |||
| @SuppressWarnings("unused") // this is used by io.quarkus.micrometer.deployment.binder.HttpBinderProcessor | |||
There was a problem hiding this comment.
I'm surprised that you get unused warnings for public classes? I think they are usually considered public APIs and thus not marked as unused.
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came to my attention while looking at quarkiverse/quarkus-langchain4j#731