Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using safe Integer comparison #41768

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Using safe Integer comparison #41768

merged 1 commit into from
Jul 9, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jul 9, 2024 •
edited
Loading

This compares using Objects.equals to avoid NPEs and comparing references instead of values

@gastaldi gastaldi requested a review from iocanel July 9, 2024 00:19
@quarkus-bot quarkus-bot

This comment was marked as outdated.

Sign in to view
@gastaldi gastaldi mentioned this pull request Jul 9, 2024
Closed
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1ad48ce.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 517ede7 into quarkusio:main Jul 9, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 9, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.2 Jul 9, 2024
@gsmet gsmet modified the milestones: 3.12.2, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
3.8.6
Development

Successfully merging this pull request may close these issues.
3 participants
@gastaldi @geoand @gsmet