Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SecureDirectoryStream to avoid FS problems and fix other minor issues in IoUtils #41787

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Jul 9, 2024

Possible fix for #41767.

Copy link

quarkus-bot bot commented Jul 9, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jul 9, 2024
@dmlloyd dmlloyd changed the title Use SecureDirectoryStream to avoid FS problems… Use SecureDirectoryStream to avoid FS problems and fix other minor issues in IoUtils Jul 9, 2024
@dmlloyd
Copy link
Member Author

dmlloyd commented Jul 9, 2024

It might be a good idea to do the same for the recursive-copy methods, but that's a bit more involved so I don't want to dig into that unless this actually solves the original issue.

Copy link

quarkus-bot bot commented Jul 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c58af08.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Kubernetes Tests - JDK 17 Build ⚠️ Check → Logs Raw logs 🚧
✔️ Kubernetes Tests - JDK 21 Logs Raw logs 🔍
✔️ Kubernetes Tests - JDK 17 Windows Logs Raw logs 🔍

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.InputCollectionOutputCollectionLambdaTest.requestHandler_InputCollectionInputPerson_OutputCollectionOutputPerson - History

  • 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Chris"] Actual: <[{outputname=Fred}]> - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Chris"]
  Actual: <[{outputname=Fred}]>

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/amazon-lambda/deployment

io.quarkus.amazon.lambda.deployment.testing.InputCollectionOutputCollectionLambdaTest.requestHandler_InputCollectionInputPerson_OutputCollectionOutputPerson - History

  • 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Fred"] Actual: <[{outputname=Chris}]> - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Fred"]
  Actual: <[{outputname=Chris}]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxTcpMetricsTest.testTcpMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@gastaldi gastaldi merged commit 8398519 into quarkusio:main Jul 10, 2024
51 of 52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 10, 2024
@dmlloyd dmlloyd deleted the ioutils branch July 10, 2024 11:26
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.3 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants