Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otel properties documentation #41891

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

brunobat
Copy link
Contributor

Current properties look like this:
Screenshot 2024-07-15 at 09 35 29

When having this interface definition:

@ConfigMapping(prefix = "quarkus.otel.exporter.otlp")
@ConfigRoot(phase = ConfigPhase.RUN_TIME)
public interface OtlpExporterRuntimeConfig extends OtlpExporterConfig

Properties override doesn't work.

This PR is a workaround.

Copy link

quarkus-bot bot commented Jul 15, 2024

/cc @radcortez (opentelemetry)

This comment has been minimized.

@brunobat
Copy link
Contributor Author

microprofile.telemetry.tracing.tck will be deactivated by #41521

Copy link

quarkus-bot bot commented Jul 15, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 29281cf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:812)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit a539f55 into quarkusio:main Jul 16, 2024
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants