Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the showmore issue to allow users to select text #41959

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

insectengine
Copy link
Contributor

@insectengine insectengine commented Jul 17, 2024

worked with @ebullient to sort out the Javascript to remove the trigger from the entire row and only make it actionable on the "show more/show less" link. This will allow users to select the copy in the TD instead of closing.

Fix quarkusio/quarkusio.github.io#2044

Copy link

quarkus-bot bot commented Jul 17, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

Copy link

quarkus-bot bot commented Jul 17, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 406e26f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 6d8339f into quarkusio:main Jul 18, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 18, 2024
Copy link

🙈 The PR is closed and the preview is expired.

@gsmet gsmet modified the milestones: 3.14 - main, 3.13.0 Jul 22, 2024
@insectengine
Copy link
Contributor Author

@gsmet - I'm not seeing the changes reflected on the site.

@gsmet
Copy link
Member

gsmet commented Jul 22, 2024

That's expected, we need a release :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

show more auto collapses making copying hard
3 participants