-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a text based 404 based on useragent #41989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@phillip-kruger mind rebasing, the PR seems stuck for some reason |
c5500fd
to
3eff48e
Compare
Rebased as Saturday is a quiet day :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I agree it looks like a neat idea. Ideally it should be based on the Accept
header instead of catching the user agent but I would merge it and see if someone complains at some point.
That being said, I suggested to make the user agent test a lot stricter as the current one is very broad.
...ttp/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/ResourceNotFoundHandler.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
3eff48e
to
c6a8248
Compare
Status for workflow
|
Fix #41969