-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Spring Data JpaRepository#getReferenceById(ID) #41993
Conversation
Won't this change remove |
Furthermore, we should have tests using both the new and the deprecated method |
Initially, I thought about keeping the StockMethodsAdder#getOne method and adding a new one. However, since getOne was private and only used in one place, I decided to refactor it instead. I renamed the method and its variables to getReferenceById. As RepositorySupport#getOne is public, I didn't delete it. Instead, I marked it as @deprecated and added a new method, RepositorySupport@getReferenceById. Regarding the tests I'm not sure to understand, I added a few tests using both. What do you exactly mean? |
I had missed those I guess. If these pass, we are fine |
This comment has been minimized.
This comment has been minimized.
Looking at this |
The problem is likely what I mentione earlier: The change seems to have removed the implementation of the |
…ethods that were lacking Fixes quarkusio#41987
Yes, it seems to be a good reason to keep adding the deprecated methods implems 😆 Let's see what the CI says |
Status for workflow
|
Can this also be backported to 3.12? My reasoning would be that the Spring API update was also done in 3.12. |
Sure yeah |
Fixes #41987