Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Oracle JDBC driver 23.4 #41998

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Jul 19, 2024

Helping @Felk with his PR #41949 , as native-image metadata got a bit tricky to handle.

Needs @tsegismont approval to ensure compatibility with the vert.x oracle pgclient. @DavideD could test this version too in Hibernate Reactive?

@Sanne Sanne requested a review from tsegismont July 19, 2024 09:52
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Jul 19, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanne LGTM, thanks

I sent and merged eclipse-vertx/vertx-sql-client#1448

The test suite passes and the upgrade will be present in Vert.x 4.5.10

@Sanne
Copy link
Member Author

Sanne commented Jul 19, 2024

Excellent, thanks!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 19, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c5c0905.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@Sanne
Copy link
Member Author

Sanne commented Jul 20, 2024

Davide told me it's working fine with Hibernate Reactive as well: good to merge.

@Sanne Sanne merged commit 1a31077 into quarkusio:main Jul 20, 2024
52 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 20, 2024
@Sanne Sanne deleted the Felk-oracle_jdbc_23.4 branch July 20, 2024 07:18
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 20, 2024
@gsmet
Copy link
Member

gsmet commented Jul 20, 2024

Nice work!

@zakkak
Copy link
Contributor

zakkak commented Jul 25, 2024

FYI this update seems to have quite some impact on the image size, see below

Test Total Size (MB) Increase from last datapoint (%) Mandrel Version Quarkus Version Previous Q version
jpa-oracle 109.5023 3.60% Mandrel-23.1.3.1-Final 1a31077 8a5ffdb
reactive-oracle-client 80.0294 6.64% Mandrel-23.1.3.1-Final 1a31077 8a5ffdb

I know there is probably not much (if any) to be done, but sharing so people are aware.

@Sanne
Copy link
Member Author

Sanne commented Jul 25, 2024

Thanks @zakkak ! Very interesting.

I suspect something related to:

But as you say, not much we can do about that; even if we could, they intend this to be used so I'd not take responsibility to change it, it might affect our users from being able to get support by the Oracle team. We'll let the Oracle JDBC team know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/native-image area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants