-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Oracle JDBC driver 23.4 #41998
Conversation
… Oracle JDBC extension
…ta with additional runtime-initialize definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sanne LGTM, thanks
I sent and merged eclipse-vertx/vertx-sql-client#1448
The test suite passes and the upgrade will be present in Vert.x 4.5.10
Excellent, thanks! |
Status for workflow
|
Davide told me it's working fine with Hibernate Reactive as well: good to merge. |
Nice work! |
FYI this update seems to have quite some impact on the image size, see below
I know there is probably not much (if any) to be done, but sharing so people are aware. |
Thanks @zakkak ! Very interesting. I suspect something related to: But as you say, not much we can do about that; even if we could, they intend this to be used so I'd not take responsibility to change it, it might affect our users from being able to get support by the Oracle team. We'll let the Oracle JDBC team know. |
Helping @Felk with his PR #41949 , as native-image metadata got a bit tricky to handle.
Needs @tsegismont approval to ensure compatibility with the vert.x oracle pgclient. @DavideD could test this version too in Hibernate Reactive?