Do not use deprecated DockerStatusBuildItem#isDockerRunning in core

[gastaldi]

/cc @edeandrea

[quarkus-bot]

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch), @yrodiere (elasticsearch)

[geoand]

How long ago was this deprecated, do we know?

[gastaldi]

It was deprecated here: #40729

[gastaldi]

Hm, since this is recent, I think I'll keep the deprecated method for now, but keep the changes to use the new method,

[edeandrea]

I did not remove it in #40729 because I didn't want to break anything in Quarkiverse/Camel that may be using it.

[geoand]

Yeah, I completely agree

[gastaldi]

Done, changed the PR title too

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7a4be43.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	Native Tests - Misc4	Build	Failures	Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Native Tests - Misc4 #

- Failing: integration-tests/opentelemetry-jdbc-instrumentation integration-tests/opentelemetry-redis-instrumentation 

📦 integration-tests/opentelemetry-jdbc-instrumentation

✖ io.quarkus.it.opentelemetry.MariaDbOpenTelemetryJdbcInstrumentationIT.testMariaDbQueryTraced - History - More details - Source on GitHub

java.lang.RuntimeException: java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class io.quarkus.it.opentelemetry.MariaDbLifecycleManager
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:375)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:118)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class io.quarkus.it.opentelemetry.MariaDbLifecycleManager
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)

✖ io.quarkus.it.opentelemetry.PostgresOpenTelemetryJdbcInstrumentationIT.testPostgreSqlQueryTraced - History - More details - Source on GitHub

java.lang.RuntimeException: java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class io.quarkus.it.opentelemetry.PostgreSqlLifecycleManager
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:375)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:118)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class io.quarkus.it.opentelemetry.PostgreSqlLifecycleManager
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)

📦 integration-tests/opentelemetry-redis-instrumentation

✖ io.quarkus.it.opentelemetry.QuarkusOpenTelemetryRedisIT.reactiveValidOperation - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/redis:7, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@18b668d)
	at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:124)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.r...

[gsmet]

Mmmmh, looks like we got issues with Docker pulling the images:

2024-07-19T15:28:17.1976345Z 2024-07-19 15:28:17,130 ERROR [com.git.doc.api.asy.ResultCallbackTemplate] (docker-java-stream--1881956780) Error during callback: com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit"}
2024-07-19T15:28:17.1978719Z 
2024-07-19T15:28:17.1979517Z 	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247)
2024-07-19T15:28:17.1981331Z 	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)

Doesn't look related to this patch though.

[gsmet]

Good cleanup, thanks. Note that the backport label is triage/backport, I fixed it.