Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing volume access modifier in Reactive MySQL client tests #42037

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix missing volume access modifier in Reactive MySQL client tests #42037

merged 1 commit into from
Jul 22, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jul 22, 2024 •
edited
Loading

Without this, you can't run the tests locally on Linux -- at least I can't, using Podman on Fedora 40.

I think CI uses a MySQL service and/or Docker, which is why it's not impacted.

@yrodiere yrodiere added the triage/needs-review Issue that needs a review - remove label if all is clear label Jul 22, 2024
@yrodiere yrodiere requested a review from tsegismont July 22, 2024 13:18
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 22, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 82f68d3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit d8886d6 into quarkusio:main Jul 22, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 22, 2024
tsegismont
tsegismont reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yrodiere . I believe I never bumped into this because I run tests with the setup similar to CI.

@gsmet gsmet modified the milestones: 3.14 - main, 3.13.0 Jul 23, 2024
@yrodiere yrodiere deleted the fix-mysql-reactive-test branch October 3, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsegismont tsegismont tsegismont left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/reactive-sql-clients triage/needs-review Issue that needs a review - remove label if all is clear
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yrodiere @gsmet @tsegismont