Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply minor polish to BuildAnalyticsProvider #42066

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Apply minor polish to BuildAnalyticsProvider #42066

merged 1 commit into from
Jul 23, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 23, 2024

  • Use final fields
  • Simplify map population of data
  • Use nanoTime instead of currentTimeMillis

@geoand
Apply minor polish to BuildAnalyticsProvider
b5a39e4 
* Use final fields
* Simplify map population of data
* Use nanoTime instead of currentTimeMillis
@geoand geoand requested a review from brunobat July 23, 2024 09:14
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jul 23, 2024
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 23, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 23, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b5a39e4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 2e2b6d7 into quarkusio:main Jul 23, 2024
51 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 23, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 23, 2024
@geoand geoand deleted the BuildAnalyticsProvider-polish branch July 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
3.14.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @brunobat