Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz - fix job refire behavior, improve dep. bean job scenario #42223

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Jul 30, 2024

Follows up on #42072 and superseeds #42096
Related to #42034

First commit fixes a case that we discussed with @mkouba over on Zulip which is that job re-fires (via JobExecutionException) should not spawn new bean instance but instead reuse existing one.
The other commit is a fix that makes sure we use the same bean instance for both, execute() and interrupt() methods.

@ilia1243 FYI, this is a follow up on the discussion from last week; hopefully this no longer has the same shortcomings :)

Copy link

quarkus-bot bot commented Jul 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2498f5c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@ilia1243
Copy link

Looks good to me, thank you for such fast response!

@mkouba mkouba merged commit 941f8db into quarkusio:main Jul 30, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 30, 2024
@manovotn manovotn deleted the issue42034_rework branch July 30, 2024 14:56
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants