WebSockets Next: CloseReason - fix NPE if connection terminated abruptly #42282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Aug 2, 2024
mkouba
commented
- fix invocation of OnClose callback with a CloseReason param
- resolves NPE in websockets-next #42271
- fix invocation of OnClose callback with a CloseReason param - resolves quarkusio#42271
geoand
approved these changes
Aug 2, 2024
geoand
added
triage/waiting-for-ci
gsmet
reviewed
Aug 2, 2024
| Short code = ws.closeStatusCode(); | ||
| if (code == null) { | ||
| // This could happen if the connection is terminated abruptly | ||
| return CloseReason.INTERNAL_SERVER_ERROR; |
There was a problem hiding this comment.
Does it make sense to return internal server error in this case?
There was a problem hiding this comment.
Well, it's kind of an internal server error. Also I did not find a better code in the list defined by the spec: https://datatracker.ietf.org/doc/html/rfc6455#section-7.4.1. There is 1006 but it's reserved and has a special meaning.
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.