Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow finer tuning of shared network usage by Keycloak DevServices #42288

Merged

Conversation

lbroudoux
Copy link
Contributor

This PR follows up #39899 and is related to the issues encountered here: microcks/microcks-quarkus#48 and there: microcks/microcks-quarkus#49.

At the moment Keycloak OIDC DevServices systematically use the shared network if it exists - leading to inconsistencies if a shared network has been initialized for other needs (see discussion #38398).

Like we did for the database-related DevServices in #39899, we should be more subtle and clearly determine if joining a shared network is required (by the user, by integration test) so that DevServices can only join on purpose.

Signed-off-by: Laurent Broudoux laurent.broudoux@gmail.com

Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com>
@quarkus-bot quarkus-bot bot added the area/oidc label Aug 2, 2024
Copy link

quarkus-bot bot commented Aug 2, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Aug 2, 2024
Copy link

quarkus-bot bot commented Aug 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e4d746e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit e034bba into quarkusio:main Aug 2, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 2, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 2, 2024
@gsmet gsmet changed the title feat: Allow funer tuning of shared network usage by Keycloak DevServices Allow finer tuning of shared network usage by Keycloak DevServices Aug 6, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants