Revert "Make sure the TestResourceManager is closed before the CL is closed" #42304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closed" This reverts commit 313e10e.
quarkus-bot
bot
added
area/core
area/devtools
|
Making draft as apparently the resource leak issue was already in 3.12.3. I still think we need to improve the flow of how these resources/CLs are closed but I'll work on that later this month. |
quarkus-bot
bot
added
triage/invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 313e10e.
Maybe related to #42298 .
We still need to fix this issue but probably in another way if it actually fixes the reported issue.