Fix Dev UI Theme switch #42310
Merged
Fix Dev UI Theme switch #42310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
phillip-kruger
added
triage/backport-3.13
and removed
area/vertx
area/dependencies
quarkus-bot
bot
added
area/dependencies
This comment has been minimized.
This comment has been minimized.
melloware
approved these changes
Aug 5, 2024
|
Nice! |
phillip-kruger
force-pushed
the
dev-ui-theme-switch
branch
from
1b3c430
to
d189e91
Compare
This comment has been minimized.
This comment has been minimized.
jmartisk
reviewed
Aug 6, 2024
extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-theme-switch.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
phillip-kruger
force-pushed
the
dev-ui-theme-switch
branch
from
d189e91
to
7d1b7eb
Compare
jmartisk
approved these changes
Aug 6, 2024
phillip-kruger
added
the
triage/waiting-for-ci
melloware
approved these changes
Aug 6, 2024
Status for workflow
|
|
Yeah, I must admit I prefer it without the mousewheel behavior too. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42297
A vaadin-web-components upgrade broke the theme switch. However, the theme switch was always a bit of a hack, example, you can click on the icon then all the options appear, and if you do not select one, but click off screen, all options disappear.
I change this to not use the menu item with the popup, but rather made the button just loop through all options [Desktop, Light, Dark] as you click. You can also use your mouse wheel to go up and down thought the themes.
I also moved the theme logic to it's own component, out of header. This is more maintainable.
/cc @xstefank @melloware