Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to always require a socket #42332

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

stuartwdouglas
Copy link
Member

I have a use case the combines both virtual dispatch and standard HTTP, this lets extensions support both.

I have a use case the combines both virtual dispatch and standard HTTP, this lets extensions support both.
Copy link

quarkus-bot bot commented Aug 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6750fe6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-3","-4","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-3","-4","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@geoand geoand merged commit cb5d48d into quarkusio:main Aug 6, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 6, 2024
@gsmet
Copy link
Member

gsmet commented Aug 6, 2024

Will push it to 3.13.1 if it applies cleanly.

@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants