Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix methos to methods typos #42436

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix methos to methods typos #42436

merged 1 commit into from
Aug 9, 2024

Conversation

xstefank
Copy link
Member

@xstefank xstefank commented Aug 9, 2024 •
edited
Loading

I noticed this in websocket.next docs, but I did a global search for "methos" :). Maybe it's the favorite typo of @mkouba :D

@xstefank xstefank requested a review from mkouba August 9, 2024 05:53
geoand
geoand approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Aug 9, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5856055.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@mkouba
Copy link
Contributor

mkouba commented Aug 9, 2024

I noticed this in websocket.next docs, but I did a global search for "methos" :). Maybe it's the favorite typo of @mkouba :D

Thanks 🤦 😄

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 9, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5856055.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit d41ab4c into quarkusio:main Aug 9, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 9, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

🙈 The PR is closed and the preview is expired.

@gsmet gsmet modified the milestones: 3.14.0.CR1, 3.13.3 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Status: Done
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xstefank @mkouba @gsmet @geoand