Qute template records: fix the way the canonical constructor is found #42439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Aug 9, 2024
mkouba
commented
- also fix the problem with compact record constructor
- resolves Qute template records: fix the way the canonical constructor is found #42411
mkouba
commented
Aug 9, 2024
| Type[] componentTypes = recordClass.recordComponents().stream().map(RecordComponentInfo::type) | ||
| .toArray(Type[]::new); | ||
| MethodInfo canonicalConstructor = recordClass.method(MethodDescriptor.INIT, componentTypes); | ||
| MethodInfo canonicalConstructor = recordClass.method(MethodDescriptor.INIT, |
There was a problem hiding this comment.
I cannot use the new ClassInfo#canonicalRecordConstructor() here because we need to get this into 3.8.
Ladicek
reviewed
Aug 9, 2024
...ons/qute/deployment/src/test/java/io/quarkus/qute/deployment/records/TemplateRecordTest.java
Outdated
Show resolved
Hide resolved
Ladicek
approved these changes
Aug 9, 2024
This comment has been minimized.
This comment has been minimized.
- also fix the problem with compact record constructor - resolves quarkusio#42411
Ladicek
approved these changes
Aug 9, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.