Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing classes for the jgit native build. #4299

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Add missing classes for the jgit native build. #4299

merged 1 commit into from
Oct 2, 2019

Conversation

andrejpetras
Copy link
Contributor

I add the missing classes for the jgit native build.

Test application: https://github.com/lorislab/fluh

@gsmet
Copy link
Member

gsmet commented Oct 1, 2019

@gastaldi can you have a look?

It might be something I could include in 0.23.2 tomorrow if we decide to merge early tomorrow.

gastaldi
gastaldi requested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some minor comments. It would be nice to have a corresponding test case if possible

extensions/jgit/deployment/src/main/java/io/quarkus/jgit/runtime/deployment/JGitProcessor.java Outdated
"com.jcraft.jsch.UserAuthGSSAPIWithMIC",
"com.jcraft.jsch.jgss.GSSContextKrb5",
"com.jcraft.jsch.jcraft.Compression",
"com.jcraft.jsch.jcraft.Compression",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is repeated:

Suggested change
"com.jcraft.jsch.jcraft.Compression",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

extensions/jgit/deployment/src/main/java/io/quarkus/jgit/runtime/deployment/JGitProcessor.java
"com.jcraft.jsch.jgss.GSSContextKrb5",
"com.jcraft.jsch.jcraft.Compression",
"com.jcraft.jsch.jcraft.Compression",
"org.eclipse.jgit.api.MergeCommand$FastForwardMode",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you group the org.eclipse.jgit classes and order the newly added items alphabetically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@andrejpetras
Copy link
Contributor Author

@gastaldi For the tests I need your help. Do we have any example how can I test it?

@gastaldi
Copy link
Contributor

gastaldi commented Oct 1, 2019

Hmm, for the tests I think it would probably require an embedded Git server with SSH enabled. I'm fine with this PR as is right now though

@gastaldi
Copy link
Contributor

gastaldi commented Oct 1, 2019

@andrejpetras can you squash your commits into a single one? That should be enough to merge this PR. Thanks!

@andrejpetras
Copy link
Contributor Author

Squash commit: done!
For the test I use the TestContainers in the this project https://github.com/lorislab/fluh
https://github.com/lorislab/fluh/blob/master/src/test/java/org/lorislab/cd/fluh/AbstractTest.java

@gsmet gsmet added the backport? label Oct 2, 2019
@gsmet gsmet merged commit d6190f4 into quarkusio:master Oct 2, 2019
@andrejpetras andrejpetras deleted the jgit-native-fix branch October 2, 2019 10:13
@gsmet gsmet removed the backport? label Oct 2, 2019
@gsmet gsmet added this to the 0.23.2 milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@andrejpetras @gsmet @gastaldi