Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertx web - use shared BodyHandler instance #4314

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Vertx web - use shared BodyHandler instance #4314

merged 1 commit into from
Oct 3, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 2, 2019

@mkouba mkouba requested a review from cescoffier October 2, 2019 08:12
@mkouba mkouba added this to the 0.24.0 milestone Oct 2, 2019
@cescoffier cescoffier added kind/bug Something isn't working area/vertx triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 2, 2019
@mkouba
Copy link
Contributor Author

mkouba commented Oct 2, 2019

Native Tests main fails with many occurrences of:

Caused by: com.oracle.svm.core.jdk.UnsupportedFeatureError: Proxy class defined by interfaces [interface javax.servlet.http.HttpServletRequest] not found. Generating proxy classes at runtime is not supported. Proxy classes need to be defined at image build time by specifying the list of interfaces that they implement. To define proxy classes use -H:DynamicProxyConfigurationFiles=<comma-separated-config-files> and -H:DynamicProxyConfigurationResources=<comma-separated-config-resources> options.

Does anybody have an idea?

@cescoffier
Copy link
Member

can you rebase, it may have been fixed.

@mkouba mkouba force-pushed the issue-4294-vertx-body-handler branch from 9225860 to 69c306d Compare October 3, 2019 09:34
@mkouba
Copy link
Contributor Author

mkouba commented Oct 3, 2019

Rebased...

@stuartwdouglas stuartwdouglas merged commit 95aa4b8 into quarkusio:master Oct 3, 2019
@cescoffier cescoffier removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/vertx kind/bug Something isn't working
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Vertx web - shared BodyHandler instance
3 participants
@mkouba @cescoffier @stuartwdouglas