Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move brotli4j dependency from netty to vertx-http #43557

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 27, 2024

Brotli4J is necessary only when using vertx-http (for now), no need to
bring it in for every app using quarkus-netty

See #43556 for more details

Marked as draft till the tests complete in my fork: https://github.com/zakkak/quarkus/actions/runs/11067441368

Copy link

github-actions bot commented Sep 27, 2024

🎊 PR Preview 2811eec has been successfully built and deployed to https://quarkus-pr-main-43557-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link
Contributor

@franz1981 franz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good finding!

@franz1981
Copy link
Contributor

FYI I've made long time ago netty/netty#12409 not sure it was useful as it should

@zakkak zakkak marked this pull request as ready for review September 27, 2024 22:05
@zakkak zakkak marked this pull request as draft September 27, 2024 22:33
@zakkak
Copy link
Contributor Author

zakkak commented Sep 27, 2024

Back to draft since I also need to adjust

.addRuntimeInitializedClass("io.netty.handler.codec.compression.BrotliOptions");

Brotli4J is necessary only when using `vertx-http` (for now), no need to
bring it in for every app using `quarkus-netty`

See quarkusio#43556 for more details
@zakkak zakkak force-pushed the 2024-09-27-brotli-dep-only-in-vertx-http branch from c86670c to 26be68d Compare September 30, 2024 05:41
@zakkak zakkak marked this pull request as ready for review September 30, 2024 05:41
Copy link

quarkus-bot bot commented Sep 30, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 26be68d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.traces.OpenTelemetryReactiveRoutesTest.root - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor\#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redis:7 at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:124) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redis:7
	at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:124)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

@gsmet gsmet merged commit b6292f4 into quarkusio:main Oct 1, 2024
68 of 69 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 1, 2024
@zakkak zakkak deleted the 2024-09-27-brotli-dep-only-in-vertx-http branch October 1, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants