-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move brotli4j dependency from netty to vertx-http #43557
Move brotli4j dependency from netty to vertx-http #43557
Conversation
🎊 PR Preview 2811eec has been successfully built and deployed to https://quarkus-pr-main-43557-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good finding!
FYI I've made long time ago netty/netty#12409 not sure it was useful as it should |
Back to draft since I also need to adjust quarkus/extensions/netty/deployment/src/main/java/io/quarkus/netty/deployment/NettyProcessor.java Line 126 in 1ff7c69
|
Brotli4J is necessary only when using `vertx-http` (for now), no need to bring it in for every app using `quarkus-netty` See quarkusio#43556 for more details
c86670c
to
26be68d
Compare
Status for workflow
|
Brotli4J is necessary only when using
vertx-http
(for now), no need tobring it in for every app using
quarkus-netty
See #43556 for more details
Marked as draft till the tests complete in my fork: https://github.com/zakkak/quarkus/actions/runs/11067441368