Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate ingress fields (annotations and rules) for kind and minikube resources #43580

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Populate ingress fields (annotations and rules) for kind and minikube resources #43580

merged 1 commit into from
Nov 6, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Sep 29, 2024 •
edited by geoand
Loading

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@mcruzdev mcruzdev marked this pull request as ready for review September 29, 2024 03:24
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Sep 29, 2024 •
edited
Loading

Hello @iocanel @metacosm, I think this one can solve the issue.

@mcruzdev mcruzdev changed the title Add Ingress annotations for kind Populate ingress fields (annotations and rules) for kind and minikube resources Sep 29, 2024
@geoand geoand requested a review from iocanel September 30, 2024 11:16
@mcruzdev mcruzdev force-pushed the issue-42294 branch 3 times, most recently from 60bec76 to 13cc3f5 Compare October 4, 2024 04:54
metacosm
metacosm reviewed Oct 4, 2024
View reviewed changes
...etes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/DevClusterHelper.java Outdated Show resolved Hide resolved
...etes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/DevClusterHelper.java
}

for (IngressRuleConfig rule : config.ingress.rules.values()) {
result.add(new DecoratorBuildItem(clusterKind, new AddIngressRuleDecorator(name, port,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also doing more than just dealing with the annotations since it also adds ingress rules (which is fine, by the way, at least in my opinion)

@mcruzdev mcruzdev force-pushed the issue-42294 branch 3 times, most recently from b970532 to 898bd66 Compare October 19, 2024 14:02
@mcruzdev
Copy link
Contributor Author

@iocanel could you take a look here? TY :)

iocanel
iocanel approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Nov 6, 2024

This one too @iocanel @metacosm :)

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 6, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 6, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7e53a5a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier cescoffier merged commit 80ea941 into quarkusio:main Nov 6, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 6, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@iocanel iocanel iocanel approved these changes

@metacosm metacosm metacosm approved these changes

Assignees
No one assigned
Labels
area/kubernetes kind/bugfix
Projects
None yet
Milestone
3.17.0.CR1
Development

Successfully merging this pull request may close these issues.

quarkus-kind does not add ingress annotations
5 participants
@mcruzdev @metacosm @iocanel @cescoffier @geoand